From 186f37e941c74004184b4930372bb21406fc43f7 Mon Sep 17 00:00:00 2001 From: Devesh Date: Wed, 4 Oct 2023 13:20:12 +0530 Subject: [PATCH 1/3] docs: update start command --- .../docs/challenges/angular-performance/36-ngfor-optimize.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/content/docs/challenges/angular-performance/36-ngfor-optimize.md b/docs/src/content/docs/challenges/angular-performance/36-ngfor-optimize.md index 2732592..5fef237 100644 --- a/docs/src/content/docs/challenges/angular-performance/36-ngfor-optimize.md +++ b/docs/src/content/docs/challenges/angular-performance/36-ngfor-optimize.md @@ -33,7 +33,7 @@ The goal of this challenge is to understand what is causing this DOM refresh and --- :::note -Start the project by running: `npx nx serve ngfor-optimize`. +Start the project by running: `npx nx serve performance-ngfor-optimize`. ::: :::tip[Reminder] From 917fba494b9cc7c2eead1d64a33e100531e92386 Mon Sep 17 00:00:00 2001 From: Devesh Date: Wed, 4 Oct 2023 21:22:17 +0530 Subject: [PATCH 2/3] docs: update projectName --- libs/cli/src/generators/challenge/generator.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libs/cli/src/generators/challenge/generator.ts b/libs/cli/src/generators/challenge/generator.ts index f829662..bad1eab 100644 --- a/libs/cli/src/generators/challenge/generator.ts +++ b/libs/cli/src/generators/challenge/generator.ts @@ -41,7 +41,10 @@ function findPreviousChallengeFilePath(tree, path, number) { } export async function challengeGenerator(tree: Tree, options: Schema) { - const { appDirectory } = getProjectDir(options.name, options.directory); + const { appProjectName, appDirectory } = getProjectDir( + options.name, + options.directory + ); const difficulty = options.challengeDifficulty; @@ -73,7 +76,7 @@ export async function challengeGenerator(tree: Tree, options: Schema) { generateFiles(tree, join(__dirname, 'files', 'readme'), appDirectory, { tmpl: '', - projectName: names(options.name).name, + projectName: appProjectName, title: options.title, challengeNumber, docRepository: options.docRepository, @@ -85,7 +88,7 @@ export async function challengeGenerator(tree: Tree, options: Schema) { `./docs/src/content/docs/challenges/${options.docRepository}`, { tmpl: '', - projectName: names(options.name).name, + projectName: appProjectName, title: options.title, challengeNumber, difficulty, From 2132eabc57cea452c2d25a434f2510570ff0b539 Mon Sep 17 00:00:00 2001 From: Devesh Date: Thu, 5 Oct 2023 13:12:10 +0530 Subject: [PATCH 3/3] docs: add appProjectName property --- .../docs/__challengeNumber__-__projectName__.md__tmpl__ | 2 +- .../src/generators/challenge/files/readme/README.md__tmpl__ | 2 +- libs/cli/src/generators/challenge/generator.ts | 6 ++++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libs/cli/src/generators/challenge/files/docs/__challengeNumber__-__projectName__.md__tmpl__ b/libs/cli/src/generators/challenge/files/docs/__challengeNumber__-__projectName__.md__tmpl__ index 561ed05..f92f20c 100644 --- a/libs/cli/src/generators/challenge/files/docs/__challengeNumber__-__projectName__.md__tmpl__ +++ b/libs/cli/src/generators/challenge/files/docs/__challengeNumber__-__projectName__.md__tmpl__ @@ -21,7 +21,7 @@ WIP: The following documentation need to be written. --- :::note -Start the project by running: `npx nx serve <%= projectName %>`. +Start the project by running: `npx nx serve <%= appProjectName %>`. ::: :::tip[Reminder] diff --git a/libs/cli/src/generators/challenge/files/readme/README.md__tmpl__ b/libs/cli/src/generators/challenge/files/readme/README.md__tmpl__ index 4305e46..1491c3d 100644 --- a/libs/cli/src/generators/challenge/files/readme/README.md__tmpl__ +++ b/libs/cli/src/generators/challenge/files/readme/README.md__tmpl__ @@ -5,7 +5,7 @@ ### Run Application ```bash -npx nx serve <%= projectName %> +npx nx serve <%= appProjectName %> ``` ### Documentation and Instruction diff --git a/libs/cli/src/generators/challenge/generator.ts b/libs/cli/src/generators/challenge/generator.ts index bad1eab..3748e5f 100644 --- a/libs/cli/src/generators/challenge/generator.ts +++ b/libs/cli/src/generators/challenge/generator.ts @@ -76,7 +76,8 @@ export async function challengeGenerator(tree: Tree, options: Schema) { generateFiles(tree, join(__dirname, 'files', 'readme'), appDirectory, { tmpl: '', - projectName: appProjectName, + projectName: names(options.name).name, + appProjectName: appProjectName, title: options.title, challengeNumber, docRepository: options.docRepository, @@ -88,7 +89,8 @@ export async function challengeGenerator(tree: Tree, options: Schema) { `./docs/src/content/docs/challenges/${options.docRepository}`, { tmpl: '', - projectName: appProjectName, + projectName: names(options.name).name, + appProjectName: appProjectName, title: options.title, challengeNumber, difficulty,