fixations via review

This commit is contained in:
Dmitriy Mishchenko
2023-10-29 16:31:31 +02:00
committed by GitHub
parent 23640dc8a3
commit 64a145d4cf

View File

@@ -32,6 +32,6 @@ While the application works, the developer experience is far from being optimal.
## Constraints ## Constraints
- You <b>must</b> refactor the `CardComponent` and `ListItemComponent`. - You <b>must</b> refactor the `CardComponent` and `ListItemComponent`.
- The `NgFor` directive must be declared and remain inside the `CardComponent`. You might be tempted to move it to the `ListItemComponent` but avoid doing so. - The `NgFor` directive must be declared and remain inside the `CardComponent`. You might be tempted to move it to the `ParentCardComponent` like `TeacherCardComponent`.
- `CardComponent` should not contain any `NgIf` or `NgSwitch`. - `CardComponent` should not contain any `NgIf` or `NgSwitch`.
- CSS: try to avoid using `::ng-deep`. Find a better way to handle CSS styling. - CSS: try to avoid using `::ng-deep`. Find a better way to handle CSS styling.