refactor: review fix

This commit is contained in:
Timothy Alcaide
2024-04-10 21:06:29 +02:00
committed by thomas
parent b00ce23792
commit 7cadcc1cf6
4 changed files with 13 additions and 13 deletions

View File

@@ -1,7 +1,7 @@
import { ApplicationConfig } from '@angular/core'; import { ApplicationConfig } from '@angular/core';
import { provideRouter } from '@angular/router'; import { provideRouter, withComponentInputBinding } from '@angular/router';
import { appRoutes } from './app.routes'; import { appRoutes } from './app.routes';
export const appConfig: ApplicationConfig = { export const appConfig: ApplicationConfig = {
providers: [provideRouter(appRoutes)], providers: [provideRouter(appRoutes, withComponentInputBinding())],
}; };

View File

@@ -1,7 +1,4 @@
import { ChangeDetectionStrategy, Component, inject } from '@angular/core'; import { ChangeDetectionStrategy, Component, input } from '@angular/core';
import { toSignal } from '@angular/core/rxjs-interop';
import { ActivatedRoute } from '@angular/router';
import { map } from 'rxjs';
@Component({ @Component({
standalone: true, standalone: true,
@@ -13,5 +10,5 @@ import { map } from 'rxjs';
changeDetection: ChangeDetectionStrategy.OnPush, changeDetection: ChangeDetectionStrategy.OnPush,
}) })
export class PageComponent { export class PageComponent {
title = toSignal(inject(ActivatedRoute).data.pipe(map((d) => d['title']))); title = input.required<string>();
} }

View File

@@ -0,0 +1,7 @@
{
"name": "Timothy Alcaide",
"github": "https://github.com/alcaidio",
"youtube": "https://www.youtube.com/@timothyalcaide",
"twitter": "https://twitter.com/alcaidio",
"linkedin": "https://www.linkedin.com/in/timothyalcaide"
}

View File

@@ -1,9 +1,9 @@
--- ---
title: 🟠 Save your form&#39;s bacon: with the navigation alert title: 🟠 Save your form&#39;s bacon: with the navigation alert
description: Challenge 48 is about Bob 🧙‍♂️ the product owner, he wants to develop a new feature in response to customer complaints about losing form input information. description: Challenge 48 is about Bob 🧙‍♂️ the product owner, he wants to develop a new feature in response to customer complaints about losing form input information.
author: Timothy Alcaide author: timothy-alcaide
contributors: contributors:
- tomalaforge - Timothy Alcaide
challengeNumber: 48 challengeNumber: 48
command: angular-dialog-alert-form command: angular-dialog-alert-form
sidebar: sidebar:
@@ -11,10 +11,6 @@ sidebar:
badge: New badge: New
--- ---
:::note
WIP: The following documentation need to be written.
:::
## Context ## Context
As a member of the development team, you need to address a specific request from the product owner, Bob 🧙‍♂️ He wants to develop a new feature in response to customer complaints about losing form input information. As a member of the development team, you need to address a specific request from the product owner, Bob 🧙‍♂️ He wants to develop a new feature in response to customer complaints about losing form input information.