From 23640dc8a3cd8e5e8f0ec1a1dc7caec2028f54c9 Mon Sep 17 00:00:00 2001 From: Dmitriy Mishchenko <51910160+dmmishchenko@users.noreply.github.com> Date: Sun, 29 Oct 2023 12:29:13 +0200 Subject: [PATCH 1/2] Update 1-projection.md --- docs/src/content/docs/challenges/angular/1-projection.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/content/docs/challenges/angular/1-projection.md b/docs/src/content/docs/challenges/angular/1-projection.md index 024f242..dfbf72c 100644 --- a/docs/src/content/docs/challenges/angular/1-projection.md +++ b/docs/src/content/docs/challenges/angular/1-projection.md @@ -32,6 +32,6 @@ While the application works, the developer experience is far from being optimal. ## Constraints - You must refactor the `CardComponent` and `ListItemComponent`. -- The `NgFor` directive must be declared and remain inside the `CardComponent`. You might be tempted to move it to the `CardComponent` but avoid doing so. +- The `NgFor` directive must be declared and remain inside the `CardComponent`. You might be tempted to move it to the `ListItemComponent` but avoid doing so. - `CardComponent` should not contain any `NgIf` or `NgSwitch`. - CSS: try to avoid using `::ng-deep`. Find a better way to handle CSS styling. From 64a145d4cf3a7ac8a6fc9dcc53ff1e51e71e9697 Mon Sep 17 00:00:00 2001 From: Dmitriy Mishchenko <51910160+dmmishchenko@users.noreply.github.com> Date: Sun, 29 Oct 2023 16:31:31 +0200 Subject: [PATCH 2/2] fixations via review --- docs/src/content/docs/challenges/angular/1-projection.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/content/docs/challenges/angular/1-projection.md b/docs/src/content/docs/challenges/angular/1-projection.md index dfbf72c..46f4484 100644 --- a/docs/src/content/docs/challenges/angular/1-projection.md +++ b/docs/src/content/docs/challenges/angular/1-projection.md @@ -32,6 +32,6 @@ While the application works, the developer experience is far from being optimal. ## Constraints - You must refactor the `CardComponent` and `ListItemComponent`. -- The `NgFor` directive must be declared and remain inside the `CardComponent`. You might be tempted to move it to the `ListItemComponent` but avoid doing so. +- The `NgFor` directive must be declared and remain inside the `CardComponent`. You might be tempted to move it to the `ParentCardComponent` like `TeacherCardComponent`. - `CardComponent` should not contain any `NgIf` or `NgSwitch`. - CSS: try to avoid using `::ng-deep`. Find a better way to handle CSS styling.