From 95d1bac6b88bbd5253a1eb409fe472b5bea814d5 Mon Sep 17 00:00:00 2001 From: Timothy Alcaide Date: Thu, 11 Apr 2024 16:41:13 +0200 Subject: [PATCH] refactor: review fix 2 --- .../form-dialog-alert}/.eslintrc.json | 0 .../form-dialog-alert}/README.md | 6 ++--- .../form-dialog-alert}/project.json | 24 +++++++++--------- .../src/app/app.component.ts | 0 .../form-dialog-alert}/src/app/app.config.ts | 0 .../form-dialog-alert}/src/app/app.routes.ts | 0 .../src/app/pages/join.component.ts | 0 .../src/app/pages/page.component.ts | 0 .../src/app/ui/dialog.component.ts | 0 .../src/app/ui/form.component.ts | 0 .../src/app/ui/nav.component.ts | 0 .../form-dialog-alert}/src/assets/.gitkeep | 0 .../form-dialog-alert}/src/favicon.ico | Bin .../form-dialog-alert}/src/index.html | 2 +- .../form-dialog-alert}/src/main.ts | 0 .../form-dialog-alert}/src/styles.scss | 0 .../form-dialog-alert}/tailwind.config.js | 0 .../form-dialog-alert}/tsconfig.app.json | 0 .../form-dialog-alert}/tsconfig.editor.json | 0 .../form-dialog-alert}/tsconfig.json | 0 docs/src/components/Author.astro | 6 ++++- docs/src/content/config.ts | 1 + .../48-dialog-alert-form.md | 6 ++--- docs/src/content/docs/es/index.mdx | 2 +- docs/src/content/docs/fr/index.mdx | 2 +- docs/src/content/docs/pt/index.mdx | 2 +- docs/src/content/docs/ru/index.mdx | 2 +- 27 files changed, 29 insertions(+), 24 deletions(-) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/.eslintrc.json (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/README.md (51%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/project.json (66%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/src/app/app.component.ts (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/src/app/app.config.ts (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/src/app/app.routes.ts (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/src/app/pages/join.component.ts (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/src/app/pages/page.component.ts (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/src/app/ui/dialog.component.ts (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/src/app/ui/form.component.ts (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/src/app/ui/nav.component.ts (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/src/assets/.gitkeep (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/src/favicon.ico (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/src/index.html (86%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/src/main.ts (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/src/styles.scss (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/tailwind.config.js (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/tsconfig.app.json (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/tsconfig.editor.json (100%) rename apps/{angular/dialog-alert-form => forms/form-dialog-alert}/tsconfig.json (100%) rename docs/src/content/docs/challenges/{angular => forms}/48-dialog-alert-form.md (93%) diff --git a/apps/angular/dialog-alert-form/.eslintrc.json b/apps/forms/form-dialog-alert/.eslintrc.json similarity index 100% rename from apps/angular/dialog-alert-form/.eslintrc.json rename to apps/forms/form-dialog-alert/.eslintrc.json diff --git a/apps/angular/dialog-alert-form/README.md b/apps/forms/form-dialog-alert/README.md similarity index 51% rename from apps/angular/dialog-alert-form/README.md rename to apps/forms/form-dialog-alert/README.md index 816a653..1ebbe0b 100644 --- a/apps/angular/dialog-alert-form/README.md +++ b/apps/forms/form-dialog-alert/README.md @@ -1,11 +1,11 @@ -# Save your form's bacon: with the navigation alert +# Save the form data with the navigation alert > author: [Timothy Alcaide](https://github.com/alcaidio) ### Run Application ```bash -npx nx serve angular-dialog-alert-form +npx nx serve form-dialog-alert ``` -Challenge documentation is [here](https://angular-challenges.vercel.app/challenges/angular/48-dialog-alert-form/). +Challenge documentation is [here](https://angular-challenges.vercel.app/challenges/forms/48-form-dialog-alert/). diff --git a/apps/angular/dialog-alert-form/project.json b/apps/forms/form-dialog-alert/project.json similarity index 66% rename from apps/angular/dialog-alert-form/project.json rename to apps/forms/form-dialog-alert/project.json index 8a2e308..24a5d4f 100644 --- a/apps/angular/dialog-alert-form/project.json +++ b/apps/forms/form-dialog-alert/project.json @@ -1,26 +1,26 @@ { - "name": "angular-dialog-alert-form", + "name": "form-dialog-alert", "$schema": "../../../node_modules/nx/schemas/project-schema.json", "projectType": "application", "prefix": "app", - "sourceRoot": "apps/angular/dialog-alert-form/src", + "sourceRoot": "apps/forms/form-dialog-alert/src", "tags": [], "targets": { "build": { "executor": "@angular-devkit/build-angular:application", "outputs": ["{options.outputPath}"], "options": { - "outputPath": "dist/apps/angular/dialog-alert-form", - "index": "apps/angular/dialog-alert-form/src/index.html", - "browser": "apps/angular/dialog-alert-form/src/main.ts", + "outputPath": "dist/apps/forms/form-dialog-alert", + "index": "apps/forms/form-dialog-alert/src/index.html", + "browser": "apps/forms/form-dialog-alert/src/main.ts", "polyfills": ["zone.js"], - "tsConfig": "apps/angular/dialog-alert-form/tsconfig.app.json", + "tsConfig": "apps/forms/form-dialog-alert/tsconfig.app.json", "inlineStyleLanguage": "scss", "assets": [ - "apps/angular/dialog-alert-form/src/favicon.ico", - "apps/angular/dialog-alert-form/src/assets" + "apps/forms/form-dialog-alert/src/favicon.ico", + "apps/forms/form-dialog-alert/src/assets" ], - "styles": ["apps/angular/dialog-alert-form/src/styles.scss"], + "styles": ["apps/forms/form-dialog-alert/src/styles.scss"], "scripts": [] }, "configurations": { @@ -51,10 +51,10 @@ "executor": "@angular-devkit/build-angular:dev-server", "configurations": { "production": { - "buildTarget": "angular-dialog-alert-form:build:production" + "buildTarget": "form-dialog-alert:build:production" }, "development": { - "buildTarget": "angular-dialog-alert-form:build:development" + "buildTarget": "form-dialog-alert:build:development" } }, "defaultConfiguration": "development" @@ -62,7 +62,7 @@ "extract-i18n": { "executor": "@angular-devkit/build-angular:extract-i18n", "options": { - "buildTarget": "angular-dialog-alert-form:build" + "buildTarget": "form-dialog-alert:build" } }, "lint": { diff --git a/apps/angular/dialog-alert-form/src/app/app.component.ts b/apps/forms/form-dialog-alert/src/app/app.component.ts similarity index 100% rename from apps/angular/dialog-alert-form/src/app/app.component.ts rename to apps/forms/form-dialog-alert/src/app/app.component.ts diff --git a/apps/angular/dialog-alert-form/src/app/app.config.ts b/apps/forms/form-dialog-alert/src/app/app.config.ts similarity index 100% rename from apps/angular/dialog-alert-form/src/app/app.config.ts rename to apps/forms/form-dialog-alert/src/app/app.config.ts diff --git a/apps/angular/dialog-alert-form/src/app/app.routes.ts b/apps/forms/form-dialog-alert/src/app/app.routes.ts similarity index 100% rename from apps/angular/dialog-alert-form/src/app/app.routes.ts rename to apps/forms/form-dialog-alert/src/app/app.routes.ts diff --git a/apps/angular/dialog-alert-form/src/app/pages/join.component.ts b/apps/forms/form-dialog-alert/src/app/pages/join.component.ts similarity index 100% rename from apps/angular/dialog-alert-form/src/app/pages/join.component.ts rename to apps/forms/form-dialog-alert/src/app/pages/join.component.ts diff --git a/apps/angular/dialog-alert-form/src/app/pages/page.component.ts b/apps/forms/form-dialog-alert/src/app/pages/page.component.ts similarity index 100% rename from apps/angular/dialog-alert-form/src/app/pages/page.component.ts rename to apps/forms/form-dialog-alert/src/app/pages/page.component.ts diff --git a/apps/angular/dialog-alert-form/src/app/ui/dialog.component.ts b/apps/forms/form-dialog-alert/src/app/ui/dialog.component.ts similarity index 100% rename from apps/angular/dialog-alert-form/src/app/ui/dialog.component.ts rename to apps/forms/form-dialog-alert/src/app/ui/dialog.component.ts diff --git a/apps/angular/dialog-alert-form/src/app/ui/form.component.ts b/apps/forms/form-dialog-alert/src/app/ui/form.component.ts similarity index 100% rename from apps/angular/dialog-alert-form/src/app/ui/form.component.ts rename to apps/forms/form-dialog-alert/src/app/ui/form.component.ts diff --git a/apps/angular/dialog-alert-form/src/app/ui/nav.component.ts b/apps/forms/form-dialog-alert/src/app/ui/nav.component.ts similarity index 100% rename from apps/angular/dialog-alert-form/src/app/ui/nav.component.ts rename to apps/forms/form-dialog-alert/src/app/ui/nav.component.ts diff --git a/apps/angular/dialog-alert-form/src/assets/.gitkeep b/apps/forms/form-dialog-alert/src/assets/.gitkeep similarity index 100% rename from apps/angular/dialog-alert-form/src/assets/.gitkeep rename to apps/forms/form-dialog-alert/src/assets/.gitkeep diff --git a/apps/angular/dialog-alert-form/src/favicon.ico b/apps/forms/form-dialog-alert/src/favicon.ico similarity index 100% rename from apps/angular/dialog-alert-form/src/favicon.ico rename to apps/forms/form-dialog-alert/src/favicon.ico diff --git a/apps/angular/dialog-alert-form/src/index.html b/apps/forms/form-dialog-alert/src/index.html similarity index 86% rename from apps/angular/dialog-alert-form/src/index.html rename to apps/forms/form-dialog-alert/src/index.html index 3b1030d..233e131 100644 --- a/apps/angular/dialog-alert-form/src/index.html +++ b/apps/forms/form-dialog-alert/src/index.html @@ -2,7 +2,7 @@ - angular-dialog-alert-form + form-dialog-alert diff --git a/apps/angular/dialog-alert-form/src/main.ts b/apps/forms/form-dialog-alert/src/main.ts similarity index 100% rename from apps/angular/dialog-alert-form/src/main.ts rename to apps/forms/form-dialog-alert/src/main.ts diff --git a/apps/angular/dialog-alert-form/src/styles.scss b/apps/forms/form-dialog-alert/src/styles.scss similarity index 100% rename from apps/angular/dialog-alert-form/src/styles.scss rename to apps/forms/form-dialog-alert/src/styles.scss diff --git a/apps/angular/dialog-alert-form/tailwind.config.js b/apps/forms/form-dialog-alert/tailwind.config.js similarity index 100% rename from apps/angular/dialog-alert-form/tailwind.config.js rename to apps/forms/form-dialog-alert/tailwind.config.js diff --git a/apps/angular/dialog-alert-form/tsconfig.app.json b/apps/forms/form-dialog-alert/tsconfig.app.json similarity index 100% rename from apps/angular/dialog-alert-form/tsconfig.app.json rename to apps/forms/form-dialog-alert/tsconfig.app.json diff --git a/apps/angular/dialog-alert-form/tsconfig.editor.json b/apps/forms/form-dialog-alert/tsconfig.editor.json similarity index 100% rename from apps/angular/dialog-alert-form/tsconfig.editor.json rename to apps/forms/form-dialog-alert/tsconfig.editor.json diff --git a/apps/angular/dialog-alert-form/tsconfig.json b/apps/forms/form-dialog-alert/tsconfig.json similarity index 100% rename from apps/angular/dialog-alert-form/tsconfig.json rename to apps/forms/form-dialog-alert/tsconfig.json diff --git a/docs/src/components/Author.astro b/docs/src/components/Author.astro index 3ac6d1b..43b3af2 100644 --- a/docs/src/components/Author.astro +++ b/docs/src/components/Author.astro @@ -6,10 +6,11 @@ interface Props { twitter?: string; linkedin?: string; github?: string; + youtube?: string; labels?: Record; } -const { name, twitter, linkedin, github, data } = Astro.props; +const { name, twitter, linkedin, github, youtube, data } = Astro.props; ---

@@ -23,6 +24,9 @@ const { name, twitter, linkedin, github, data } = Astro.props; {github && } + {youtube && + + }

diff --git a/docs/src/content/config.ts b/docs/src/content/config.ts index 011bd3e..15a0095 100644 --- a/docs/src/content/config.ts +++ b/docs/src/content/config.ts @@ -8,6 +8,7 @@ const authors = defineCollection({ twitter: z.string().url().optional(), linkedin: z.string().url().optional(), github: z.string().url().optional(), + youtube: z.string().url().optional(), }), }); diff --git a/docs/src/content/docs/challenges/angular/48-dialog-alert-form.md b/docs/src/content/docs/challenges/forms/48-dialog-alert-form.md similarity index 93% rename from docs/src/content/docs/challenges/angular/48-dialog-alert-form.md rename to docs/src/content/docs/challenges/forms/48-dialog-alert-form.md index 473dded..6e94a8a 100644 --- a/docs/src/content/docs/challenges/angular/48-dialog-alert-form.md +++ b/docs/src/content/docs/challenges/forms/48-dialog-alert-form.md @@ -1,11 +1,11 @@ --- -title: 🟠 Save your form's bacon: with the navigation alert +title: 🟠 Save the form data with the navigation alert description: Challenge 48 is about Bob 🧙‍♂️ the product owner, he wants to develop a new feature in response to customer complaints about losing form input information. author: timothy-alcaide contributors: - - Timothy Alcaide + - alcaidio challengeNumber: 48 -command: angular-dialog-alert-form +command: form-dialog-alert sidebar: order: 121 badge: New diff --git a/docs/src/content/docs/es/index.mdx b/docs/src/content/docs/es/index.mdx index 53822e0..58b4b09 100644 --- a/docs/src/content/docs/es/index.mdx +++ b/docs/src/content/docs/es/index.mdx @@ -13,7 +13,7 @@ hero: icon: right-arrow variant: primary - text: Ir al Desafío más reciente - link: /es/challenges/angular/48-dialog-alert-form/ + link: /es/challenges/forms/48-form-dialog-alert/ icon: rocket - text: Dar una estrella link: https://github.com/tomalaforge/angular-challenges diff --git a/docs/src/content/docs/fr/index.mdx b/docs/src/content/docs/fr/index.mdx index e3272aa..50c3e87 100644 --- a/docs/src/content/docs/fr/index.mdx +++ b/docs/src/content/docs/fr/index.mdx @@ -13,7 +13,7 @@ hero: icon: right-arrow variant: primary - text: Aller au dernier Challenge - link: /fr/challenges/angular/48-dialog-alert-form/ + link: /fr/challenges/forms/48-form-dialog-alert/ icon: rocket - text: Donne une étoile link: https://github.com/tomalaforge/angular-challenges diff --git a/docs/src/content/docs/pt/index.mdx b/docs/src/content/docs/pt/index.mdx index 9f6c57b..7475a43 100644 --- a/docs/src/content/docs/pt/index.mdx +++ b/docs/src/content/docs/pt/index.mdx @@ -13,7 +13,7 @@ hero: icon: right-arrow variant: primary - text: Ir para o desafio mais recente - link: /pt/challenges/angular/48-dialog-alert-form/ + link: /pt/challenges/forms/48-form-dialog-alert/ icon: rocket - text: Dar uma estrela link: https://github.com/tomalaforge/angular-challenges diff --git a/docs/src/content/docs/ru/index.mdx b/docs/src/content/docs/ru/index.mdx index 72bd83a..d5ead27 100644 --- a/docs/src/content/docs/ru/index.mdx +++ b/docs/src/content/docs/ru/index.mdx @@ -13,7 +13,7 @@ hero: icon: right-arrow variant: primary - text: Перейти к последней задаче - link: /ru/challenges/angular/48-dialog-alert-form/ + link: /ru/challenges/forms/48-form-dialog-alert/ icon: rocket - text: Добавить звезду link: https://github.com/tomalaforge/angular-challenges