From a2ab48f153d2d3d031792680b7b8e4572ef7c319 Mon Sep 17 00:00:00 2001 From: thomas laforge Date: Sun, 13 Nov 2022 15:48:07 +0100 Subject: [PATCH] fix: error caused by ng move --- apps/crud/README.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/crud/README.md b/apps/crud/README.md index b768010..9438937 100644 --- a/apps/crud/README.md +++ b/apps/crud/README.md @@ -17,7 +17,7 @@ Currently we have a working exemple but filled with lots of bad practices. What you will need to do: - Avoid **any** as a type. Using Interface to leverage Typescript type system prevent errors -- Use a **separate service** for all your crud calls and use a **BehaviourSubject** for your todoList +- Use a **separate service** for all your http calls and use a **BehaviourSubject** for your todoList - Use **AsyncPipe** to suscribe to your todo list. _(Let you handle subscription, unsuscription and refresh of the page when data has changed)_, avoir manual subscribe when it's not needed - Don't **mutate** data @@ -36,7 +36,7 @@ this.todos = [ ### Step 2: Improve -- Add a **Delete** button: _Doc of fake API_ +- Add a **Delete** button: _Doc of fake API_ - Handle **errors** correctly. _(Globaly)_ - Add a Global **loading** indicator. _You can use MatProgressSpinnerModule_ @@ -59,6 +59,6 @@ this.todos = [ 6. Commit your work 7. Submit a PR with a title beginning with **Answer:3** that I will review and other dev can review. -Http +Http -_You can ask any question on_ Twitter +_You can ask any question on_ Twitter