docs: ngrx notification comments

This commit is contained in:
jdegand
2024-01-12 12:53:02 -05:00
parent c8b7c5d4a6
commit b5eefff9cf
3 changed files with 4 additions and 4 deletions

View File

@@ -1,5 +1,6 @@
import { createActionGroup, emptyProps } from '@ngrx/store'; import { createActionGroup, emptyProps } from '@ngrx/store';
// This is the global actions.
export const appActions = createActionGroup({ export const appActions = createActionGroup({
source: 'App Component', source: 'App Component',
events: { events: {

View File

@@ -31,9 +31,8 @@ export class NotificationService {
); );
} }
if (isSchool(notification)) { if (isSchool(notification)) {
// SchoolStore is not providedin root. thus at initialization, SchoolStore is undefined // SchoolStore is a ComponentStore. We can't dispatch a school action here.
// Option 1: set SchoolStore in root, but we don't want this to separate our class. // We are stuck. We must have done something wrong and need to refactor...
// Option 2: your turn
} }
}); });
} }

View File

@@ -35,7 +35,7 @@ export class SchoolStore
this.httpService.getAllSchools().pipe( this.httpService.getAllSchools().pipe(
tapResponse( tapResponse(
(schools) => this.patchState({ schools }), (schools) => this.patchState({ schools }),
(_) => _, (_) => _, // not handling the error
), ),
), ),
), ),