refactor: review fix 2

This commit is contained in:
Timothy Alcaide
2024-04-11 16:41:13 +02:00
committed by thomas
parent 7cadcc1cf6
commit 95d1bac6b8
27 changed files with 29 additions and 24 deletions

View File

@@ -1,11 +1,11 @@
# Save your form's bacon: with the navigation alert # Save the form data with the navigation alert
> author: [Timothy Alcaide](https://github.com/alcaidio) > author: [Timothy Alcaide](https://github.com/alcaidio)
### Run Application ### Run Application
```bash ```bash
npx nx serve angular-dialog-alert-form npx nx serve form-dialog-alert
``` ```
Challenge documentation is [here](https://angular-challenges.vercel.app/challenges/angular/48-dialog-alert-form/). Challenge documentation is [here](https://angular-challenges.vercel.app/challenges/forms/48-form-dialog-alert/).

View File

@@ -1,26 +1,26 @@
{ {
"name": "angular-dialog-alert-form", "name": "form-dialog-alert",
"$schema": "../../../node_modules/nx/schemas/project-schema.json", "$schema": "../../../node_modules/nx/schemas/project-schema.json",
"projectType": "application", "projectType": "application",
"prefix": "app", "prefix": "app",
"sourceRoot": "apps/angular/dialog-alert-form/src", "sourceRoot": "apps/forms/form-dialog-alert/src",
"tags": [], "tags": [],
"targets": { "targets": {
"build": { "build": {
"executor": "@angular-devkit/build-angular:application", "executor": "@angular-devkit/build-angular:application",
"outputs": ["{options.outputPath}"], "outputs": ["{options.outputPath}"],
"options": { "options": {
"outputPath": "dist/apps/angular/dialog-alert-form", "outputPath": "dist/apps/forms/form-dialog-alert",
"index": "apps/angular/dialog-alert-form/src/index.html", "index": "apps/forms/form-dialog-alert/src/index.html",
"browser": "apps/angular/dialog-alert-form/src/main.ts", "browser": "apps/forms/form-dialog-alert/src/main.ts",
"polyfills": ["zone.js"], "polyfills": ["zone.js"],
"tsConfig": "apps/angular/dialog-alert-form/tsconfig.app.json", "tsConfig": "apps/forms/form-dialog-alert/tsconfig.app.json",
"inlineStyleLanguage": "scss", "inlineStyleLanguage": "scss",
"assets": [ "assets": [
"apps/angular/dialog-alert-form/src/favicon.ico", "apps/forms/form-dialog-alert/src/favicon.ico",
"apps/angular/dialog-alert-form/src/assets" "apps/forms/form-dialog-alert/src/assets"
], ],
"styles": ["apps/angular/dialog-alert-form/src/styles.scss"], "styles": ["apps/forms/form-dialog-alert/src/styles.scss"],
"scripts": [] "scripts": []
}, },
"configurations": { "configurations": {
@@ -51,10 +51,10 @@
"executor": "@angular-devkit/build-angular:dev-server", "executor": "@angular-devkit/build-angular:dev-server",
"configurations": { "configurations": {
"production": { "production": {
"buildTarget": "angular-dialog-alert-form:build:production" "buildTarget": "form-dialog-alert:build:production"
}, },
"development": { "development": {
"buildTarget": "angular-dialog-alert-form:build:development" "buildTarget": "form-dialog-alert:build:development"
} }
}, },
"defaultConfiguration": "development" "defaultConfiguration": "development"
@@ -62,7 +62,7 @@
"extract-i18n": { "extract-i18n": {
"executor": "@angular-devkit/build-angular:extract-i18n", "executor": "@angular-devkit/build-angular:extract-i18n",
"options": { "options": {
"buildTarget": "angular-dialog-alert-form:build" "buildTarget": "form-dialog-alert:build"
} }
}, },
"lint": { "lint": {

View File

Before

Width:  |  Height:  |  Size: 15 KiB

After

Width:  |  Height:  |  Size: 15 KiB

View File

@@ -2,7 +2,7 @@
<html lang="en"> <html lang="en">
<head> <head>
<meta charset="utf-8" /> <meta charset="utf-8" />
<title>angular-dialog-alert-form</title> <title>form-dialog-alert</title>
<base href="/" /> <base href="/" />
<meta name="viewport" content="width=device-width, initial-scale=1" /> <meta name="viewport" content="width=device-width, initial-scale=1" />
<link rel="icon" type="image/x-icon" href="favicon.ico" /> <link rel="icon" type="image/x-icon" href="favicon.ico" />

View File

@@ -6,10 +6,11 @@ interface Props {
twitter?: string; twitter?: string;
linkedin?: string; linkedin?: string;
github?: string; github?: string;
youtube?: string;
labels?: Record<string, string>; labels?: Record<string, string>;
} }
const { name, twitter, linkedin, github, data } = Astro.props; const { name, twitter, linkedin, github, youtube, data } = Astro.props;
--- ---
<p class="author"> <p class="author">
@@ -23,6 +24,9 @@ const { name, twitter, linkedin, github, data } = Astro.props;
{github && <a href={github}> {github && <a href={github}>
<Icon class="icon" name="github" size="0.75rem" /> <Icon class="icon" name="github" size="0.75rem" />
</a>} </a>}
{youtube && <a href={youtube}>
<Icon class="icon" name="youtube" size="0.75rem" />
</a>}
</p> </p>

View File

@@ -8,6 +8,7 @@ const authors = defineCollection({
twitter: z.string().url().optional(), twitter: z.string().url().optional(),
linkedin: z.string().url().optional(), linkedin: z.string().url().optional(),
github: z.string().url().optional(), github: z.string().url().optional(),
youtube: z.string().url().optional(),
}), }),
}); });

View File

@@ -1,11 +1,11 @@
--- ---
title: 🟠 Save your form&#39;s bacon: with the navigation alert title: 🟠 Save the form data with the navigation alert
description: Challenge 48 is about Bob 🧙‍♂️ the product owner, he wants to develop a new feature in response to customer complaints about losing form input information. description: Challenge 48 is about Bob 🧙‍♂️ the product owner, he wants to develop a new feature in response to customer complaints about losing form input information.
author: timothy-alcaide author: timothy-alcaide
contributors: contributors:
- Timothy Alcaide - alcaidio
challengeNumber: 48 challengeNumber: 48
command: angular-dialog-alert-form command: form-dialog-alert
sidebar: sidebar:
order: 121 order: 121
badge: New badge: New

View File

@@ -13,7 +13,7 @@ hero:
icon: right-arrow icon: right-arrow
variant: primary variant: primary
- text: Ir al Desafío más reciente - text: Ir al Desafío más reciente
link: /es/challenges/angular/48-dialog-alert-form/ link: /es/challenges/forms/48-form-dialog-alert/
icon: rocket icon: rocket
- text: Dar una estrella - text: Dar una estrella
link: https://github.com/tomalaforge/angular-challenges link: https://github.com/tomalaforge/angular-challenges

View File

@@ -13,7 +13,7 @@ hero:
icon: right-arrow icon: right-arrow
variant: primary variant: primary
- text: Aller au dernier Challenge - text: Aller au dernier Challenge
link: /fr/challenges/angular/48-dialog-alert-form/ link: /fr/challenges/forms/48-form-dialog-alert/
icon: rocket icon: rocket
- text: Donne une étoile - text: Donne une étoile
link: https://github.com/tomalaforge/angular-challenges link: https://github.com/tomalaforge/angular-challenges

View File

@@ -13,7 +13,7 @@ hero:
icon: right-arrow icon: right-arrow
variant: primary variant: primary
- text: Ir para o desafio mais recente - text: Ir para o desafio mais recente
link: /pt/challenges/angular/48-dialog-alert-form/ link: /pt/challenges/forms/48-form-dialog-alert/
icon: rocket icon: rocket
- text: Dar uma estrela - text: Dar uma estrela
link: https://github.com/tomalaforge/angular-challenges link: https://github.com/tomalaforge/angular-challenges

View File

@@ -13,7 +13,7 @@ hero:
icon: right-arrow icon: right-arrow
variant: primary variant: primary
- text: Перейти к последней задаче - text: Перейти к последней задаче
link: /ru/challenges/angular/48-dialog-alert-form/ link: /ru/challenges/forms/48-form-dialog-alert/
icon: rocket icon: rocket
- text: Добавить звезду - text: Добавить звезду
link: https://github.com/tomalaforge/angular-challenges link: https://github.com/tomalaforge/angular-challenges