vcgit-forge/angular-challenges
1
0
Fork 0
mirror of https://github.com/Raghu-Ch/angular-challenges.git synced 2026-02-10 12:53:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: error caused by ng move

Browse Source
This commit is contained in:
thomas laforge
2022-11-13 15:48:07 +01:00
parent e24cd09745
commit a2ab48f153
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
apps/crud/README.md
View File

@@ -17,7 +17,7 @@ Currently we have a working exemple but filled with lots of bad practices.
What you will need to do: What you will need to do:
- Avoid **any** as a type. Using Interface to leverage Typescript type system prevent errors - Avoid **any** as a type. Using Interface to leverage Typescript type system prevent errors
- Use a **separate service** for all your crud calls and use a **BehaviourSubject** for your todoList - Use a **separate service** for all your http calls and use a **BehaviourSubject** for your todoList
- Use **AsyncPipe** to suscribe to your todo list. _(Let you handle subscription, unsuscription and refresh of the page when data has changed)_, avoir manual subscribe when it's not needed - Use **AsyncPipe** to suscribe to your todo list. _(Let you handle subscription, unsuscription and refresh of the page when data has changed)_, avoir manual subscribe when it's not needed
- Don't **mutate** data - Don't **mutate** data
@@ -36,7 +36,7 @@ this.todos = [
### Step 2: Improve ### Step 2: Improve
- Add a **Delete** button: _<a href="cruds://jsonplaceholder.typicode.com/" target="_blank">Doc of fake API</a>_ - Add a **Delete** button: _<a href="https://jsonplaceholder.typicode.com/" target="_blank">Doc of fake API</a>_
- Handle **errors** correctly. _(Globaly)_ - Handle **errors** correctly. _(Globaly)_
- Add a Global **loading** indicator. _You can use MatProgressSpinnerModule_ - Add a Global **loading** indicator. _You can use MatProgressSpinnerModule_
@@ -59,6 +59,6 @@ this.todos = [
6. Commit your work 6. Commit your work
7. Submit a PR with a title beginning with **Answer:3** that I will review and other dev can review. 7. Submit a PR with a title beginning with **Answer:3** that I will review and other dev can review.
<a href="cruds://github.com/tomalaforge/angular-challenges/pulls?q=label%3A5+label%3Aanswer" target="_blank"><img src="cruds://img.shields.io/badge/-Solutions-green" alt="Http"/></a> <a href="https://github.com/tomalaforge/angular-challenges/pulls?q=label%3A5+label%3Aanswer" target="_blank"><img src="https://img.shields.io/badge/-Solutions-green" alt="Http"/></a>
_You can ask any question on_ <a href="cruds://twitter.com/laforge_toma" target="_blank"><img src="./../../logo/twitter.svg" height=20px alt="Twitter"/></a> _You can ask any question on_ <a href="https://twitter.com/laforge_toma" target="_blank"><img src="./../../logo/twitter.svg" height=20px alt="Twitter"/></a>